[m-rev.] for post-commit review and opinions: warn option classification
Zoltan Somogyi
zoltan.somogyi at runbox.com
Mon May 19 16:24:17 AEST 2025
On Mon, 19 May 2025 15:41:59 +1000, Julien Fischer <jfischer at opturion.com> wrote:
> This is a review of the diff; I'll look at the proposal separately.
The two have almost the same info; most of the proposal just *explains*
the changes in the diff.
> > - oc_warn_c: options that control other warnings,
> > - oc_warn_ns: options that warn about possible bugs (non-style warnings)
> > - oc_warn_s: style warnings
> > - oc_warn_i: requests for information
>
> I suggest:
>
> oc_warn_control
> oc_warn_correctness
> oc_warn_style
> oc_inform
>
> I don't think brevity helps in this case.
It very much does. Without it, the clauses of the optdef predicate
don't usually fit on one line. (And this fact is the reason for the
shortness of the "optdef" name.)
> The diff is fine.
Thank you.
Zoltan.
More information about the reviews
mailing list