[m-rev.] for post-commit review and opinions: warn option classification

[Julien Fischer]

On Mon, 19 May 2025 at 16:24, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
>
>
>
> On Mon, 19 May 2025 15:41:59 +1000, Julien Fischer <jfischer at opturion.com> wrote:
> > This is a review of the diff; I'll look at the proposal separately.
>
> The two have almost the same info; most of the proposal just *explains*
> the changes in the diff.
>
> > > - oc_warn_c:  options that control other warnings,
> > > - oc_warn_ns: options that warn about possible bugs (non-style warnings)
> > > - oc_warn_s:  style warnings
> > > - oc_warn_i:  requests for information
> >
> > I suggest:
> >
> >     oc_warn_control
> >     oc_warn_correctness
> >     oc_warn_style
> >     oc_inform
> >
> > I don't think brevity helps in this case.
>
> It very much does. Without it, the clauses of the optdef predicate
> don't usually fit on one line. (And this fact is the reason for the
> shortness of the "optdef" name.)

We can abbreviate a little

   oc_warn_ctrl
   oc_warn_correct
   oc_warn_style
   oc_inform

Even though oc_warn_correct is now the longest of the option_categroy
constructors,
it's now only by one letter.  (I'm tempted to rename oc_warn_correct
to oc_warn_dodgy ...)

Julien.