[m-rev.] for post-commit review and opinions: warn option classification

Julien Fischer jfischer at opturion.com
Mon May 19 15:41:59 AEST 2025


Hi,

This is a review of the diff; I'll look at the proposal separately.

On Mon, 19 May 2025 at 02:43, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> Split the oc_warn option category into four parts ...
>
> ... which contain respectively
>
> - oc_warn_c:  options that control other warnings,
> - oc_warn_ns: options that warn about possible bugs (non-style warnings)
> - oc_warn_s:  style warnings
> - oc_warn_i:  requests for information

I suggest:

    oc_warn_control
    oc_warn_correctness
    oc_warn_style
    oc_inform

I don't think brevity helps in this case.

The diff is fine.

Julien.


More information about the reviews mailing list