[m-rev.] For review: Fix seg fault bug in declarative debugger.

Zoltan Somogyi zs at cs.mu.OZ.AU
Wed Nov 24 11:10:53 AEDT 2004


On 24-Nov-2004, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> >  	#ifdef MR_EXEC_TRACE
> > -		TracingOn = ML_bool_return_yes();
> > +		TracingOn = MR_TRUE;
> >  	#else
> > -		TracingOn = ML_bool_return_no();
> > +		TracingOn = MR_FALSE;
> >  	#endif
> >  ").
> >
> Are MR_TRUE and MR_FALSE always going to be the same as yes and no?

The original reason why we used ML_bool_return_{yes,no} instead of constants
was the .rt grade, which we don't support anymore. However, I would feel
easier if we added a comment to the implementation section of bool.m
giving the mapping yes->MR_TRUE, no->MR_FALSE.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list