[m-rev.] For review: Fix seg fault bug in declarative debugger.

[Julien Fischer]

On Wed, 24 Nov 2004, Zoltan Somogyi wrote:

> On 24-Nov-2004, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> > >  	#ifdef MR_EXEC_TRACE
> > > -		TracingOn = ML_bool_return_yes();
> > > +		TracingOn = MR_TRUE;
> > >  	#else
> > > -		TracingOn = ML_bool_return_no();
> > > +		TracingOn = MR_FALSE;
> > >  	#endif
> > >  ").
> > >
> > Are MR_TRUE and MR_FALSE always going to be the same as yes and no?
>
> The original reason why we used ML_bool_return_{yes,no} instead of constants
> was the .rt grade, which we don't support anymore.

Using ML_bool_return_{yes,no} seems more future-proof.  Are we ever
likely to have another grade that has different values for yes and no?

> However, I would feel
> easier if we added a comment to the implementation section of bool.m
> giving the mapping yes->MR_TRUE, no->MR_FALSE.
>
Likewise.  Such a comment should also be added to runtime/mercury_std.h.
(There is already one to that effect in runtime/mercury_bootstrap.h).

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------