[m-rev.] For review: Fix seg fault bug in declarative debugger.
Julien Fischer
juliensf at cs.mu.OZ.AU
Wed Nov 24 02:02:44 AEDT 2004
On Wed, 24 Nov 2004, Ian MacLarty wrote:
> For review by anyone.
>
> Estimated hours taken: 5
> Branches: main
>
> Fix seg fault bug in declarative debugger.
>
> Allow shared libraries to be linked against using lmc.
>
> browser/declarative_tree.m
> The will_not_call_mercury promise was a fib, since
> ML_bool_return_yes/no were exported Mercury procs. So just return
> constants instead.
>
> tools/lmc.in
> Allow shared versions of the libraries to be linked against using
> lmc. I needed this since the seg fault only occured when linking
> against the shared versions of the libraries.
>
> Index: browser/declarative_tree.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/browser/declarative_tree.m,v
> retrieving revision 1.9
> diff -u -r1.9 declarative_tree.m
> --- browser/declarative_tree.m 19 Nov 2004 11:54:17 -0000 1.9
> +++ browser/declarative_tree.m 23 Nov 2004 12:43:12 -0000
> @@ -1455,9 +1455,9 @@
> [promise_pure, will_not_call_mercury, thread_safe],
> "
> #ifdef MR_EXEC_TRACE
> - TracingOn = ML_bool_return_yes();
> + TracingOn = MR_TRUE;
> #else
> - TracingOn = ML_bool_return_no();
> + TracingOn = MR_FALSE;
> #endif
> ").
>
Are MR_TRUE and MR_FALSE always going to be the same as yes and no?
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list