[m-rev.] for review: deep profiling.

[Fergus Henderson]

On 04-May-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> On 04-May-2001, Thomas Conway <conway at cs.mu.OZ.AU> wrote:
> > You don't seem to have included a diff for the deep directory.
> 
> Sorry about that. The diff follows, together with the relevant part of a
> (slightly updated) log message.
> 
> > > +#define procname	""det_call_port_code_ac""
> > > +#define version_ac
> > > +#undef need_new_outermost
> > > +#include ""mercury_deep_call_port_body.h""
> > > +#undef procname
> > > +#undef version_ac
> > > +}").
> > > +
> > 
> > Shouldn't these macro names have MR_ prefixes or some other
> > appropriate namespacing (also for the rest of profiling_builtin.m)?
> 
> Not really, because they do not encroach on the user's namespace. They are
> all explicitly undefined after being used.

OK, but according to our coding guidelines they should be all-uppercase, since
they are macros (and not function-like macros).

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------