[m-rev.] for review: deep profiling.

Thomas Conway conway at cs.mu.OZ.AU
Sat May 5 10:14:28 AEST 2001


On Fri, May 04, 2001 at 06:18:11PM EST, Zoltan Somogyi wrote:

> +% This module allows you build a description of a directed graph (represented
> +% as a set of arcs between nodes identified by integers) and then find the

The comments probably should specify dense "small" integers because the
code behaves badly if you use sparse large integers (ie pointers interpreted
as integers).

> +delete(A0, I) = A :-
> +	max(A0, Max),
> +	( I > Max ->
> +		A = A0
> +	; I >= 0 ->
> +		lookup(A0, word(I), Word0),
> +		Word = Word0 /\ \ bit(I),
> +		set(A0, word(I), Word, A)
> +	;
> +		error("insert: cannot use indexes < 0")

s/insert/delete/

> +:- type fields	==	string.		% some subset of "pqtaw", meaning

If the fields characters must be sorted, then let me suggest
s/pqtaw/apqtw/

> +					% p: port counts
> +					% q: quanta
> +					% t: times
> +					% a: memory allocations
> +					% w: memory words
> +					% The characters must be sorted.
> +

-- 
  Thomas Conway )O+
 <conway at cs.mu.oz.au>       499 User error! Replace user, and press any key.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list