[m-rev.] for review: fix .NET commit handling

[Fergus Henderson]

On 11-Jul-2001, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> On 11-Jul-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > There shouldn't be an XXX on that comment.
> > An XXX would indicate something that we ought to fix later,
> > but this comment is just explaining why it was done the
> > way it was, not pointing out a hack or suggesting something
> > that could be fixed later.
> 
> Sorry, I intended to fix it later.  This has bitten me once and Pete
> once so I wanted to fix it.  But the XXX should go on mlds.m.

Ah, you want to change the `maybe' type there to a different d.u.,
to make it clearer what the "no" means, e.g.

	:- type mlds__function_body
		--->	defined_here(mlds__statement)
		;	external.

or something like that?
That is a good idea.

> > However, I suppose it's more important get it working first.
> > So I suggest you go ahead and commit that.
> > I'll fix the modularity problems.
> 
> I would prefer to commit my followup.

OK, the ml_code_gen.m bit is fine; the mlds_to_il.m bit is mostly fine too (see
my review comments in the other mail), but it looks to me like an unrelated change,
and if so, it should be committed separately.

> This is the interdiff for it:

Ah, *now* he posts it! ;-)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------