[m-rev.] for review: fix .NET commit handling

Tyson Dowd trd at cs.mu.OZ.AU
Wed Jul 11 23:17:54 AEST 2001


On 11-Jul-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 11-Jul-2001, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> > On 11-Jul-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > > There shouldn't be an XXX on that comment.
> > > An XXX would indicate something that we ought to fix later,
> > > but this comment is just explaining why it was done the
> > > way it was, not pointing out a hack or suggesting something
> > > that could be fixed later.
> > 
> > Sorry, I intended to fix it later.  This has bitten me once and Pete
> > once so I wanted to fix it.  But the XXX should go on mlds.m.
> 
> Ah, you want to change the `maybe' type there to a different d.u.,
> to make it clearer what the "no" means, e.g.
> 
> 	:- type mlds__function_body
> 		--->	defined_here(mlds__statement)
> 		;	external.
> 
> or something like that?
> That is a good idea.

Yes, this would be a very good idea.  

In fact it is so easy I will do it now.

> > This is the interdiff for it:
> 
> Ah, *now* he posts it! ;-)

Better late than never...

-- 
       Tyson Dowd           # 
                            #  Surreal humour isn't everyone's cup of fur.
     trd at cs.mu.oz.au        # 
http://www.cs.mu.oz.au/~trd #
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list