[m-rev.] for review: keep the invocation automatically up-to-date
Peter Wang
novalazy at gmail.com
Wed Jul 23 17:39:48 AEST 2025
On Wed, 23 Jul 2025 16:35:34 +1000 Julien Fischer <jfischer at opturion.com> wrote:
> On Wed, 23 Jul 2025 at 15:54, Peter Wang <novalazy at gmail.com> wrote:
>
> > I can commit the following. Any thoughts about committing the generated file?
>
> There are trade-offs either way. Committing the generated file relies on people
> keeping it up-to-date. While that is easier than having to update
> separate copies
> of the documentation in options.m and the user guide, I would bet it
> would still be
> missed every once in while.
Not very often, though. It's no different from what we do with
getopt_io.m and certain other generated files.
> Generating the file does make the assumption that
> when cross-compiling or building the source distribution, the
> bootstrap compiler is
> up-to-date. For the source distribution builds that always be the
> case, the source
> distribution is built from the same git commit as the compiler used to build it.
> I couldn't say what happens in the cross compilation scenario, but I
> would assume
> it is usually done with the same version of the compiler?
Usually, but it doesn't have to be.
> On balance, I think generating the file rather than committing is preferable.
> (The diff looks fine, please commit it.)
Done.
Peter
More information about the reviews
mailing list