[m-rev.] for post-commit review: convert all remaining non-grade options

[Julien Fischer]

On Tue, 1 Jul 2025 at 00:06, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> Convert the rest of the non-grade options to use semantic help_pieces.
>
> compiler/options.m:
>     As above.
>
> compiler/optdb_help.m:
> compiler/print_help.m:
>     Define and implement some new semantic categories,
>     to help with the change to options.m.
>
>     Fix a bug in print_help.m: we were ignoring any changes in the
>     length of the current line caused by processing help_text_only
>     and/or texinfo_info pieces.
>
> tests/warnings/help_text.err_exp:
>     Expect the updated help texts.

...

> diff --git a/compiler/options.m b/compiler/options.m
> index 0489ecaf9..bac22dfb1 100644
> --- a/compiler/options.m
> +++ b/compiler/options.m

...

> @@ -5478,17 +5504,17 @@ optdb(oc_internal,  allow_defn_of_builtins,            bool(no),
>  optdb(oc_internal,  type_ctor_info,                    bool(yes),
>      priv_help("type-ctor-info", [
>          w("Do not generate type_ctor_info structures. For measurement only;"),
> -        w("if you turn this off, then you're unlikely to be able to link.")])).
> +        w("if you turn this off, then you will not be able to link.")])).
>  optdb(oc_internal,  type_ctor_layout,                  bool(yes),
>      priv_help("type-ctor-layout", [
>          w("Do not generate type_ctor_layout structures."),
>          w("For measurement only;"),
> -        w("if you turn this off, then you're unlikely to be able to link.")])).
> +        w("if you turn this off, then you will not to be able to link.")])).
>  optdb(oc_internal,  type_ctor_functors,                bool(yes),
>      priv_help("type-ctor-functors", [
>          w("Do not gGenerate type_ctor_functors structures."),

s/gGenerate/generate/

>          w("For measurement only;"),
> -        w("if you turn this off, then you're unlikely to be able to link.")])).
> +        w("if you turn this off, then you will not to be able to link.")])).
>  optdb(oc_internal,  rtti_line_numbers,                 bool(yes),
>      priv_help("rtti-line-numbers", [
>          w("Generate line number information in the RTTI when debugging is"),
> @@ -5499,7 +5525,7 @@ optdb(oc_internal,  new_type_class_rtti,               bool(no),
>          w("Generate of new style static data structures"),
>          w("for runtime information about type classes."),
>          w("These are not yet used. When we add code to generate the matching"),
> -        w("dynamic data structures and switch over to use them, we won't"),
> +        w("dynamic data structures and switch over to use them, we will not"),
>          w("need this option anymore.")])).
>  % These two options are used to analyze the performance effects
>  % of minimal model tabling.
> @@ -5546,27 +5572,29 @@ optdb(oc_internal,  max_specialized_do_call_class_method, int(6), no_help).
>      % max_spec_explicit_arg in tools/make_spec_method_call.
>  optdb(oc_internal,  compare_specialization,            int(-1),
>      % -1 asks handle_options.m to give the value, which may be grade dependent.
> -    priv_arg_help("compare-specialization", "n", [
> +    priv_arg_help("compare-specialization", "N", [
>          w("Generate quadratic instead of linear compare predicates for"),
> -        w("types with up to n function symbols. Higher values of n lead to"),
> +        w("types with up to N function symbols. Higher values of n lead to"),

s/n/N/

The rest looks fine.

Julien.