[m-rev.] for post-commit review: convert analysis to target options

Julien Fischer jfischer at opturion.com
Tue Jul 1 10:48:23 AEST 2025


On Mon, 30 Jun 2025 at 19:24, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> Convert analysis/output_mod/make/target options to semantic help_pieces.
>
> compiler/options.m:
>     As above.
>
> tests/warnings/help_text.err_exp:
>     Expect the updated help texts.
>
> diff --git a/compiler/options.m b/compiler/options.m
> index 1b9bec697..29b2138e1 100644
> --- a/compiler/options.m
> +++ b/compiler/options.m

...

>  %---------------------%
> @@ -4177,11 +4181,12 @@ optdb(oc_target_c,  c_include_directories,             accumulating([]),
>      % determined at configuration time.
>      alt_arg_help("c-include-directory",
>              ["c-include-dir"], "dir", [
> -        w("Append <dir> to the list of directories to be searched for"),
> -        w("C header files. Note that if you want to override"),
> -        w("this list, rather than append to it, then you can set the"),
> -        w("`MERCURY_MC_ALL_C_INCL_DIRS' environment variable to a"),
> -        w("sequence of `--c-include-directory' options.")])).
> +        w("Append"), arg("dir"), w("to the list of directories"),
> +        w("to be searched for C header files."),
> +        w("Note that if you want to override this list, instead of"),
> +        w("appendding to it, then you can set the"),

s/appendding/appending/

The rest looks fine.

Julien.


More information about the reviews mailing list