[m-rev.] for review: changes to mmake and bootcheck

Julien Fischer jfischer at opturion.com
Tue Jun 18 23:44:57 AEST 2019


On Tue, 18 Jun 2019, Zoltan Somogyi wrote:

> For the diff to mmake, the main question is the parsing cost of the spaces.

I wouldn't have thought it would be significant?

> For bootcheck, my question is not really about the diff, but whether we should
> build the slice, profiler, deep_profiler and mfilterjavac directories in stage 3?
> At the moment, we do not, so we do not compare them to stage 2. I think
> we (I) should fix this. Any objections?

No objections from me.

Julien.


More information about the reviews mailing list