[m-rev.] for review: chop up a big module

[Paul Bone]

On Thu, Jan 27, 2011 at 06:03:12AM +1100, Zoltan Somogyi wrote:
> 
> Start dividing a big module with low cohesion into several smaller, high
> cohesion modules.
> 
> deep_profiler/mdprof_fb.automatic_parallelism.m:
> 	Distribute the contents of this module among five new submodules.
> 	Replace those contents with just the inclusions of the new submodules.
> 
> deep_profiler/autopar_tannier.m:
> 	The part of the old module implementing Jerome Tannier's algorithms.

This can probably be deleted, (CVS will remember) since we did the same to the
compiler half of this work.

> deep_profiler/autopar_types.m:
> 	The part of the old module defining generally useful types
> 	and the operations on them.
> 
> deep_profiler/autopar_annotate.m:
> 	The part of the old module that annotated the representations of goals.

This should really be instmap.m, since it could be used by other analyses.

More generally, each annotation should be in it's own module.

> deep_profiler/autopar_find_best_par.m:
> 	The part of the old module that performed the search for the best way
> 	to parallelize a conjuncyion.
> 
> deep_profiler/autopar_util.m:
> 	The rest of the old module; it still has low cohesion.
> 	I will chop it into smaller pieces over the next couple of days.

I'd rather call this autopar_callgraph_search.m and move the utility code
elsewhere.  I understand that you'll split it up but I recommend calling it
autopar_callgraph_search.m and at a later stage moving the other code out.

The rest is fine.

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20110127/219f8fe3/attachment.sig>