[m-rev.] for post-commit review: fix bug #243: memory zone leak on Windows

Julien Fischer juliensf at csse.unimelb.edu.au
Wed Dec 7 18:05:10 AEDT 2011


On Wed, 7 Dec 2011, Ian MacLarty wrote:

> On Wed, Dec 7, 2011 at 12:41 PM, Julien Fischer
> <juliensf at csse.unimelb.edu.au> wrote:
>>
>> On Wed, 7 Dec 2011, Ian MacLarty wrote:
>>
>>> On Wed, Dec 7, 2011 at 4:54 AM, Julien Fischer
>>> <juliensf at csse.unimelb.edu.au> wrote:
>>>>
>>>>
>>>> For post-commit review by Ian.
>>>> (Peter Ross might also want to have a look at this one.)
>>>>
>>>> Ian, this differs a little bit from the diff I sent you the other day.
>>>> (The changes are related to MSVC stuff.)
>>>>
>>>
>>> Looks fine, although I didn't see anything related to MSVC specifically.
>>
>>
>> If you looked at the diff, then you did.  Just because the letters MSVC
>> weren't used doesn't mean the code isn't MSVC specific.
>>
>
> The only difference I can see between this diff and your previous one
> is the change in mercury_memory_handlers.c.  How does that relate to
> MSVC?

It's inside a section of code that is protected by 
MR_USE_MSVC_EXCEPTION_HANDLERS, i.e. that whole section is MSVC
specific.

Julien.


More information about the reviews mailing list