[m-rev.] for post-commit review: fix bug #243: memory zone leak on Windows

Ian MacLarty maclarty at csse.unimelb.edu.au
Wed Dec 7 13:27:46 AEDT 2011


On Wed, Dec 7, 2011 at 12:41 PM, Julien Fischer
<juliensf at csse.unimelb.edu.au> wrote:
>
> On Wed, 7 Dec 2011, Ian MacLarty wrote:
>
>> On Wed, Dec 7, 2011 at 4:54 AM, Julien Fischer
>> <juliensf at csse.unimelb.edu.au> wrote:
>>>
>>>
>>> For post-commit review by Ian.
>>> (Peter Ross might also want to have a look at this one.)
>>>
>>> Ian, this differs a little bit from the diff I sent you the other day.
>>> (The changes are related to MSVC stuff.)
>>>
>>
>> Looks fine, although I didn't see anything related to MSVC specifically.
>
>
> If you looked at the diff, then you did.  Just because the letters MSVC
> weren't used doesn't mean the code isn't MSVC specific.
>

The only difference I can see between this diff and your previous one
is the change in mercury_memory_handlers.c.  How does that relate to
MSVC?

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list