[m-rev.] for review: don't make asm label functions static

Julien Fischer juliensf at csse.unimelb.edu.au
Thu Jul 8 04:37:36 AEST 2010


On Wed, 7 Jul 2010, Ian MacLarty wrote:

> On Tue, Jul 6, 2010 at 3:31 PM, Paul Bone <pbone at csse.unimelb.edu.au> wrote:
>> On Tue, Jul 06, 2010 at 12:17:33PM +1000, Ian MacLarty wrote:
>>> For review by anyone.
>>>
>>
>> Thanks Ian,
>>
>> Julien and I are happy with this.  Could you also bootcheck it using GCC 3.4?
>> We have gcc-3.4 installed on taura.
>>
>
> Bootcheck with gcc-3.4 passes, so I've committed this.

rotd-2010-07-07 is very broken on x86-64 in the asm_fast.gc grades, (the
generated executables seg fault when initialising the standard library.)
This is presumably what PeterW mentioned yesterday afternoon.

What optimization options did you bootcheck with?  It appears that
everything is fine at -O2, but the nightly builds are broken on the
following machines:

 	taura		gcc 4.4		-O5 --intermod-opt
 	goliath		gcc 4.1		-O5 --intermod-opt
 	neptune		gcc 4.1		-O4
 	saturn 		gcc 4.3		-O5 --intermod-opt

The only one of the x86-64 machines on which it is working is goofy,
which builds at -O2 (it's also gcc 4.1).

Julien.


More information about the reviews mailing list