[m-rev.] for review: speedup some dependency computation in mmc --make

Peter Wang novalazy at gmail.com
Wed Jun 25 14:36:32 AEST 2008

On 2008-06-25, Zoltan Somogyi <zs at csse.unimelb.edu.au> wrote:
> On 25-Jun-2008, Peter Wang <novalazy at gmail.com> wrote:
> > In one workspace, `mmc --make' now takes 2 seconds to check that all the .c
> > files in the compiler directory are up to date.  Previously, it took 132
> > seconds.
> That's great!
> Any idea what the pathological behavior was?

Sorry, the first part of find_transitive_module_dependencies_2 checks if
the current module is already seen; the patch makes that always succeed.
i.e. it's completely wrong.  I knew it was too good to be true.


mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au

More information about the reviews mailing list