[m-rev.] for review: speedup some dependency computation in mmc --make

[Zoltan Somogyi]

On 25-Jun-2008, Peter Wang <novalazy at gmail.com> wrote:
> In one workspace, `mmc --make' now takes 2 seconds to check that all the .c
> files in the compiler directory are up to date.  Previously, it took 132
> seconds.

That's great!

Any idea what the pathological behavior was?

>  :- pred find_transitive_module_dependencies(transitive_dependencies_type::in,
> -    module_locn::in, module_name::in, bool::out, set(module_name)::out,
> -    make_info::in, make_info::out, io::di, io::uo) is det.
> +    module_locn::in, module_name::in, bool::out, set(module_name)::in,
> +    set(module_name)::out, make_info::in, make_info::out, io::di, io::uo)
> +    is det.

Normally, I like to keep the declaration of in,out pairs of arguments
on the same line. Otherwise, the diff seems fine.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------