[m-rev.] for review: moose fixes

Julien Fischer juliensf at students.cs.mu.OZ.AU
Wed Jul 23 07:15:34 AEST 2003

On Wed, 23 Jul 2003, Fergus Henderson wrote:

> On 22-Jul-2003, Julien Fischer <juliensf at students.cs.mu.OZ.AU> wrote:
> >
> > Allow moose to parse conditional goals written using the if - then - else
> > notation.  This makes the code generated by moose less ugly when the `.moo'
> > file contains these type of goals.
> The changes that you posted look fine, but I think there are a few
> things that you missed:
> 	- Don't you need to also modify term_to_ite
> 	  (in extras/moose/mercury_syntax.m) to handle the
> 	  new kind of it-then-else goals?
On closer inspection term_to_ite and a number of other predicates
aren't actually used.  Moose compiles and runs quite happily without
them.  Are they just dead code or was there some (unimplemented) purpose
to them?

I wasn't actually intending to preserve the difference between
the two notations for if-then-else goals in the generated code
(although if anyone yells loudly enough ...)

> 	- The new syntax should be documented
> 	  (in the extras/moose/README file).
> 	  [In fact, the old syntax for if-then-else also needs
> 	  documenting, I think.]
Why?  It's just normal Mercury syntax - no other syntax (other than moose
specific declarations) are mentioned in the README file.

mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe

More information about the reviews mailing list