[m-rev.] for review: moose fixes

Fergus Henderson fjh at cs.mu.OZ.AU
Wed Jul 23 04:55:51 AEST 2003

On 22-Jul-2003, Julien Fischer <juliensf at students.cs.mu.OZ.AU> wrote:
> Allow moose to parse conditional goals written using the if - then - else
> notation.  This makes the code generated by moose less ugly when the `.moo'
> file contains these type of goals.

The changes that you posted look fine, but I think there are a few
things that you missed:

	- Don't you need to also modify term_to_ite
	  (in extras/moose/mercury_syntax.m) to handle the
	  new kind of it-then-else goals?

	- The new syntax should be documented
	  (in the extras/moose/README file). 

	  [In fact, the old syntax for if-then-else also needs
	  documenting, I think.]

	- There should be a test case for the new feature.

Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe

More information about the reviews mailing list