[m-dev.] for review: begin type_ctor_* simplification

Tyson Dowd trd at cs.mu.OZ.AU
Thu Apr 8 13:39:17 AEST 1999


On 08-Apr-1999, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 06-Apr-1999, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> > +	/*
> > +	** Structs defining the structure of type_ctor_infos.
> > +	**
> > +	** XXX this is not used yet but we are aiming towards
> > +	** this structure.
> > +	*/
> > +
> >  typedef struct {
> > +	int arity;
> > +	Code *unify_pred;
> > +	Code *index_pred;
> > +	Code *compare_pred;
> > +	MR_TypeCtorRepresentation type_ctor_rep;
> > +	MR_TypeCtorFunctors type_ctor_functors;
> > +	MR_TypeCtorLayout type_ctor_layout;
> > +	String type_ctor_name;
> > +	String type_ctor_module_name;
> > +} MR_TypeCtorInfo;
> 
> A brief comment here explaining the distinction between the three
> type_ctor_* members would be helpful.  I know it is explained elsewhere
> but explaining it briefly here would help people reading this code
> for the first time.

Ok.

> Otherwise that change looks fine.
> 
> When you make the next part of it, the part that requires this change
> to bootstrap, remember to modify configure.in to change the bootstrapping
> test to detect this.

In the past we have only modified the bootstrapping test at release time.
Are you proposing we change our policy to try to make it always correct?

-- 
The quantum sort: 
	while (!sorted) { do_nothing(); }
Tyson Dowd   <tyson at tyse.net>   http://tyse.net/



More information about the developers mailing list