[m-dev.] for review: begin type_ctor_* simplification

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Apr 8 01:05:39 AEST 1999


On 06-Apr-1999, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> +	/*
> +	** Structs defining the structure of type_ctor_infos.
> +	**
> +	** XXX this is not used yet but we are aiming towards
> +	** this structure.
> +	*/
> +
>  typedef struct {
> +	int arity;
> +	Code *unify_pred;
> +	Code *index_pred;
> +	Code *compare_pred;
> +	MR_TypeCtorRepresentation type_ctor_rep;
> +	MR_TypeCtorFunctors type_ctor_functors;
> +	MR_TypeCtorLayout type_ctor_layout;
> +	String type_ctor_name;
> +	String type_ctor_module_name;
> +} MR_TypeCtorInfo;

A brief comment here explaining the distinction between the three
type_ctor_* members would be helpful.  I know it is explained elsewhere
but explaining it briefly here would help people reading this code
for the first time.

Otherwise that change looks fine.

When you make the next part of it, the part that requires this change
to bootstrap, remember to modify configure.in to change the bootstrapping
test to detect this.

Cheers,
	Fergus.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.



More information about the developers mailing list