[m-dev.] trivial diff: buxfix for the security fix.

Tyson Dowd trd at stimpy.cs.mu.oz.au
Tue Mar 31 15:49:04 AEST 1998


On 30-Mar-1998, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 30-Mar-1998, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> > scripts/mmake.in:
> > 	Bugfix for previous change, mmake wasn't working on murlibobo.
> > 	"if ! mkdir... " seems to be a bash-ism.  Use mkdir ...., then
> > 	check $? instead.
> 
> I wondered about that when I reviewed the change, so I tried it out
> on a couple of machines -- but not Alphas.
> 
> As a minor stylistic point I think
> 
> 	if mkdir ... then
> 		true
> 	else
> 		...
> 	fi
> 	...
> 
> would be very slightly nicer than using $? and case.

Done.  Zoltan also fixed ml.in, which had a similar error.  Hopefully
this should be the end of it (except of course for the bug I found in
mktemp while doing this stuff).

-- 
       Tyson Dowd           # So I asked Sarah: what's the serial number on
                            # your computer? She replied:
     trd at cs.mu.oz.au        #          A-C-2-4-0-V-/-5-0-H-Z
http://www.cs.mu.oz.au/~trd #



More information about the developers mailing list