[m-dev.] trivial diff: buxfix for the security fix.

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Mar 30 20:37:40 AEST 1998


On 30-Mar-1998, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> scripts/mmake.in:
> 	Bugfix for previous change, mmake wasn't working on murlibobo.
> 	"if ! mkdir... " seems to be a bash-ism.  Use mkdir ...., then
> 	check $? instead.

I wondered about that when I reviewed the change, so I tried it out
on a couple of machines -- but not Alphas.

As a minor stylistic point I think

	if mkdir ... then
		true
	else
		...
	fi
	...

would be very slightly nicer than using $? and case.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.



More information about the developers mailing list