[m-rev.] for post-commit review: start updating mlds_to_cs_name.m

Julien Fischer jfischer at opturion.com
Mon May 15 10:00:09 AEST 2023


On Thu, 11 May 2023, Zoltan Somogyi wrote:

> More updates to mlds_to_cs_name.m.
> 
> compiler/mlds_to_cs_name.m:
>     Delete some of the predicates that do I/O, requiring their all callers
>     to call their function versions instead.
>
>     Add a comment at the top explaining the reason for length limiting
>     identifiers.
> 
> compiler/mlds_to_cs_export.m:
> compiler/mlds_to_cs_func.m:
> compiler/mlds_to_cs_global.m:
>     Conform to the changes in mlds_to_cs_name.m.
>
>     Include as many things as possible in calls to io.format, because
>     doing so allows people reading the code can see how those items
>     fit together.
> 
> compiler/mlds_to_cs_data.m:
> compiler/mlds_to_cs_stmt.m:
>     Conform to the changes in mlds_to_cs_name.m.

That's fine.

Julien.


More information about the reviews mailing list