[m-rev.] for post-commit review: start updating mlds_to_cs_name.m

Julien Fischer jfischer at opturion.com
Mon May 15 09:52:07 AEST 2023


On Thu, 11 May 2023, Zoltan Somogyi wrote:

> Start to update mlds_to_cs_name.m.
> 
> compiler/mlds_to_cs_name.m:
>     For most of the predicates that write out (processed versions of) names,
>     add
>
>     - a function version that returns the processed name as a string; and
>     - a function version that returns the processed name *after* it has
>       had its length reduced below 511 characters, if needed.
>
>     The first version has "nll_string" (non-length-limited string)
>     in its name; the second has "ll_string" (length-limited string) instead.
>
>     Apply the same naming scheme to some existing functions.
>
>     Turn predicates that return strings into functions.
>
>     Add and export a function to do the length limitation.
> 
> compiler/mlds_to_cs_data.m:
> compiler/mlds_to_cs_type.m:
>     Conform to the changes in mlds_to_cs_name.m.

That's fine.

Julien.


More information about the reviews mailing list