[m-rev.] for post-commit review: use indent.m in mlds_to_java_*.m

Julien Fischer jfischer at opturion.com
Thu May 11 08:37:17 AEST 2023


On Thu, 11 May 2023, Zoltan Somogyi wrote:

> On 2023-05-10 16:26 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:

>> Given the nature of this change I assume you have done
>> a bootcheck in the java grade?
>
> Yes, several. The earlier ones showed some test failures caused by
> the kinds of bugs I believe you are worried about, which I have now fixed.
> It was precisely because I wanted to know which test failures are new
> that I added the recent diff to tools/bootcheck.
>
> What I found was not very pretty. With pretty much every java bootcheck,
> there are some test failures caused by NoClassDefnFoundError exceptions,
> which occur, as far as I can tell, which is admittedly not very far, occur
> randomly: they occur on one bootcheck, and go away with the next,
> even though nothing done in between to the compiler seems likely
> to affect them. Does anyone have any idea about why this happens?

Are you running the tests in parallel? IIRC, that kind of thing occurs
because one process is in the process of overwriting the .class files
required by another (e.g where tests share source files).

(I've just started a bootcheck at -j1 on my machine -- I'll let you know
if the problem occurs there.)

Julien.


More information about the reviews mailing list