[m-rev.] for post-commit review: use indent.m in mlds_to_java_*.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu May 11 03:16:51 AEST 2023


On 2023-05-10 16:26 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
>> Make mlds_to_java_*.m use indent.m.
> That's fine.

Thank you.

> Given the nature of this change I assume you have done
> a bootcheck in the java grade?

Yes, several. The earlier ones showed some test failures caused by
the kinds of bugs I believe you are worried about, which I have now fixed.
It was precisely because I wanted to know which test failures are new
that I added the recent diff to tools/bootcheck.

What I found was not very pretty. With pretty much every java bootcheck,
there are some test failures caused by NoClassDefnFoundError exceptions,
which occur, as far as I can tell, which is admittedly not very far, occur
randomly: they occur on one bootcheck, and go away with the next,
even though nothing done in between to the compiler seems likely
to affect them. Does anyone have any idea about why this happens?

Zoltan.


More information about the reviews mailing list