[m-rev.] diff: workaround bug #304

[Julien Fischer]

On Tue, Jan 14, 2014 at 4:13 PM, Paul Bone <paul at bone.id.au> wrote:

> On Tue, Jan 14, 2014 at 03:44:37PM +1100, Julien Fischer wrote:
> >
> > Branches: master, 14.01
> >
> > ----------------------
> >
> > Workaround bug #304.
> >
> > configure.ac:
> >       When using non-local gotos force GCC 4.8 to emit error messages
> >       in a format that mfiltercc can handle.
> >
>
> I've noticed that there are two different styles of doing this kind of
> thing, and we use both.  This may be another opportunity to standardise or
> at least discuss which style is preferred:
>
>     A: As you've done here, check a compiler's version number and if high
>        it "matches" then pass some options.
>
>     B) Test is the compiler supports the options, and pass them if it does.
>
> I'd suggest that we use B in this kind of case where all compilers
> supporting these options are likely to have the same problem (due to the
> new
> feature).
>

I'll look at modifying this workaround to do that, but not just now (I'm
busy).

Cheers,
Julien.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20140114/1a870775/attachment.html>