<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jan 14, 2014 at 4:13 PM, Paul Bone <span dir="ltr"><<a href="mailto:paul@bone.id.au" target="_blank">paul@bone.id.au</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Tue, Jan 14, 2014 at 03:44:37PM +1100, Julien Fischer wrote:<br>
><br>
> Branches: master, 14.01<br>
><br>
> ----------------------<br>
><br>
> Workaround bug #304.<br>
><br>
> <a href="http://configure.ac" target="_blank">configure.ac</a>:<br>
> When using non-local gotos force GCC 4.8 to emit error messages<br>
> in a format that mfiltercc can handle.<br>
><br>
<br>
</div>I've noticed that there are two different styles of doing this kind of<br>
thing, and we use both. This may be another opportunity to standardise or<br>
at least discuss which style is preferred:<br>
<br>
A: As you've done here, check a compiler's version number and if high<br>
it "matches" then pass some options.<br>
<br>
B) Test is the compiler supports the options, and pass them if it does.<br>
<br>
I'd suggest that we use B in this kind of case where all compilers<br>
supporting these options are likely to have the same problem (due to the new<br>
feature).<br></blockquote><div><br></div><div>I'll look at modifying this workaround to do that, but not just now (I'm busy).</div><div><br></div><div>Cheers,</div><div>Julien.</div></div><br></div></div>