[m-rev.] for review: improve variable naming in init_duration/7
Julien Fischer
jfischer at opturion.com
Fri Mar 6 21:14:29 AEDT 2026
On Fri, 6 Mar 2026 at 20:38, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
>
>
>
> On Fri, 6 Mar 2026 19:56:13 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> > + % Internally, the inputs are normalised into four components: months,
> > + % days, seconds and microseconds.
>
> Break the line after the colon.
Done.
>
> > + % Normalise months: convert years into months and add that to
> > + % count of months.
>
> Here and in two of the later lines: add a comma before "and".
> Also, *the* count of months.
Done.
Thanks for that.
Julien.
More information about the reviews
mailing list