[m-rev.] for review: improve variable naming in init_duration/7

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Mar 6 20:38:26 AEDT 2026



On Fri, 6 Mar 2026 19:56:13 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> +        % Internally, the inputs are normalised into four components: months,
> +        % days, seconds and microseconds.

Break the line after the colon.

> +        % Normalise months: convert years into months and add that to
> +        % count of months.

Here and in two of the later lines: add a comma before "and".
Also, *the* count of months.

The diff is otherwise fine. The new names are much better than
the old ones.

Zoltan.



More information about the reviews mailing list