[m-rev.] for post-commit review: split possible_cause into hint and inconsistent

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Jun 12 00:31:33 AEST 2024


On 2024-06-11 17:42 +10:00 AEST, "Peter Wang" <novalazy at gmail.com> wrote:
> On Fri, 07 Jun 2024 17:41:21 +1000 Peter Wang <novalazy at gmail.com> wrote:
>> 
>> I'll try to make suggestions for the 256 color modes soon.
> 
> Here are my suggestions for the 256 color modes.
> 
> dark256
> specified at subject=111:correct=107:incorrect=174:inconsistent=179:hint=140
> 
> light256
> specified at subject=27:correct=28:incorrect=160:inconsistent=166:hint=92
> 
> where
> 
> color 111:  #87afff  rgb(135, 175, 255)  oklch(0.76, 0.124, 263)
> color 107:  #87af5f  rgb(135, 175,  95)  oklch(0.71, 0.117, 131)
> color 174:  #d78787  rgb(215, 135, 135)  oklch(0.71, 0.099, 20)
> color 179:  #d7af5f  rgb(215, 175,  95)  oklch(0.77, 0.109, 83)
> color 140:  #af87d7  rgb(175, 135, 215)  oklch(0.69, 0.122, 306)
> 
> color  27:  #005fff  rgb(  0,  95, 255)  oklch(0.55, 0.249, 262)
> color  28:  #008700  rgb(  0, 135,   0)  oklch(0.54, 0.184, 142)
> color 160:  #d70000  rgb(215,   0,   0)  oklch(0.55, 0.227, 29)
> color 166:  #d75f00  rgb(215,  95,   0)  oklch(0.63, 0.172, 48)
> color  92:  #8700d7  rgb(135,   0, 215)  oklch(0.50, 0.261, 304)

Thanks for that. Sorry to be a pest, but while this info is still in your head,
could you please pick 24 bit colors for each role? The attached diff, which I am
committing, adds support for them. I think it is simple enough not to need review,
but I wouldn't mind being corrected.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.c24
Type: application/octet-stream
Size: 490 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240612/f50ae8e9/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.c24
Type: application/octet-stream
Size: 8770 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240612/f50ae8e9/attachment-0001.obj>


More information about the reviews mailing list