[m-rev.] for post-commit review: split possible_cause into hint and inconsistent

[Peter Wang]

On Fri, 07 Jun 2024 08:47:48 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> The concept has been agreed and the implementation
> is straightforward, so really the feedback I am looking for
> is for Peter to pick an updated color scheme. But Peter,
> please do not update the code yourself, as I intend to keep
> working on the affected modules, and that would cause
> a conflict for me.
> 
> Zoltan.

> diff --git a/compiler/globals.m b/compiler/globals.m
> index 071ed2b83..c66673b96 100644
> --- a/compiler/globals.m
> +++ b/compiler/globals.m
> @@ -878,65 +879,74 @@ record_color_scheme_in_options(Source, SchemeName, ErrorSpecs, InformSpecs,
>          InformSpecs = []
>      else if
>          % XXX COLOR While we have agreed on the names of the standard schemes,
> -        % the colors in those schemes are just placeholders for now.
> +        % and on the colors to be used in the *16 schemes for the subject,
> +        % correct and incorrect roles, the other colors below are just
> +        % placeholders for now.
>          (
>              ( SchemeName = "dark16"
>              ; SchemeName = "darkmode16"
>              ),
> -            Subject =   "14",   % bright cyan
> -            Correct =   "10",   % bright green
> -            Incorrect = "9",    % bright red
> -            Cause =     "11"    % bright yellow
> +            Subject =       "14",   % bright cyan
> +            Correct =       "10",   % bright green
> +            Incorrect =     "9",    % bright red
> +            Inconsistent =  "13",   % bright magenta
> +            Hint =          "11"    % bright yellow
>          ;
>              ( SchemeName = "dark256"
>              ; SchemeName = "darkmode256"
>              ),
> -            Subject =   "14",   % bright cyan
> -            Correct =   "10",   % bright green
> -            Incorrect = "9",    % bright red
> -            Cause =     "11"    % bright yellow
> +            Subject =       "14",   % bright cyan
> +            Correct =       "10",   % bright green
> +            Incorrect =     "9",    % bright red
> +            Inconsistent =  "13",   % bright magenta
> +            Hint =          "11"    % bright yellow
>          ;
>              ( SchemeName = "light16"
>              ; SchemeName = "lightmode16"
>              ),
> -            Subject =   "6",    % normal cyan
> -            Correct =   "2",    % normal green
> -            Incorrect = "9",    % bright red
> -            Cause =     "8"     % normal yellow
> +            Subject =       "6",    % normal cyan
> +            Correct =       "2",    % normal green
> +            Incorrect =     "9",    % bright red
> +            Inconsistent =  "5",    % normal magenta
> +            Hint =          "8"     % normal yellow

Normal yellow is 3, not 8.

>          ;
>              ( SchemeName = "light256"
>              ; SchemeName = "lightmode256"
>              ),
> -            Subject =   "6",    % normal cyan
> -            Correct =   "2",    % normal green
> -            Incorrect = "9",    % bright red
> -            Cause =     "8"     % normal yellow
> +            Subject =       "6",    % normal cyan
> +            Correct =       "2",    % normal green
> +            Incorrect =     "9",    % bright red
> +            Inconsistent =  "5",    % normal magenta
> +            Hint =          "8"     % normal yellow
>          )

Also here.

How about swapping yellow and magenta, yellow for "inconsistent",
magenta for "hint". My reasoning is... traffic light colours.

dark16
specified at subject=14:correct=10:incorrect=9:inconsistent=11:hint=13

light16
specified at subject=6:correct=2:incorrect=9:inconsistent=3:hint=5

I'll try to make suggestions for the 256 color modes soon.

Peter