[m-rev.] for post-commit review: use actual types in groundness tests
Julien Fischer
jfischer at opturion.com
Wed Jul 3 11:25:14 AEST 2024
On Wed, 3 Jul 2024 at 02:22, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
>
>
> On 2024-07-02 22:22 +10:00 AEST, "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> >
> > On 2024-07-02 22:20 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
> >> I haven't had a chance to review this yet, but either this change or
> >> the following one appear
> >> to have broken compilation of the library in the
> >> asm_fast.gc.profdeep.tr.stseg grade in this
> >> evening's rotd build.
> >
> > I will have a look.
>
> This diff fixes the bug.
Thanks for that.
> My bootcheck in that grade now works
> with only one failed test case, trailing/test_trail_reset. Since I don't usually
> bootcheck in trailing grade, I don't know whether that is normal.
Failures in that directory in non-profdeep trailing grades are not normal.
With rotd-2024-07-01, test_trail_reset seem appear to be invoking the function
trail entries more times than in the non-profdeep cases; if that's what you are
observing then it's nothing caused by this change.
Julien.
More information about the reviews
mailing list