[m-rev.] for post-commit review: use actual types in groundness tests

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Jul 3 02:22:09 AEST 2024


On 2024-07-02 22:22 +10:00 AEST, "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> On 2024-07-02 22:20 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
>> I haven't had a chance to review this yet, but either this change or
>> the following one appear
>> to have broken compilation of the library in the
>> asm_fast.gc.profdeep.tr.stseg grade in this
>> evening's rotd build.
> 
> I will have a look.

This diff fixes the bug. My bootcheck in that grade now works
with only one failed test case, trailing/test_trail_reset. Since I don't usually
bootcheck in trailing grade, I don't know whether that is normal.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.pr
Type: application/octet-stream
Size: 186 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240703/5d0f91ea/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.pr
Type: application/octet-stream
Size: 3842 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240703/5d0f91ea/attachment-0001.obj>


More information about the reviews mailing list