[m-rev.] for post-commit review: implement PROPOSED searches for .a, .init, .jar and .dll files

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Dec 13 22:18:27 AEDT 2024



On Thu, 12 Dec 2024 11:31:10 +1100 (AEDT), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> On Wed, 4 Dec 2024 23:37:50 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> 
> > On Wed, 4 Dec 2024 at 02:58, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> > 
> > > On Tue, 3 Dec 2024 19:10:19 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> > > > > I think that the conceptually cleanest solution of this bug is to make
> > > > > the --libgrade option serve only the second purpose, eliminating (1)
> > > > > from the preference order entirely. We would compute the set of installed
> > > > > stdlib grades in handle_options.m just after we compute chosen_stdlib_dir,
> > > > > and record the result in a new slot in the globals structure.
> > > >
> > > > That seems a reasonable suggestion.
> > >
> > > Then I will implement it, including the include/exclude-component bits.
> 
> The attached diff does this; it is for review by anyone. The diff
> adds a new, non-misleading name for the option now named --detect-libgrades.

In the absence of a review by then, I intend to commit this diff
tomorrow around noon.

Zoltan.


More information about the reviews mailing list