[m-rev.] for post-commit review: implement PROPOSED searches for .a, .init, .jar and .dll files

[Zoltan Somogyi]

On Wed, 4 Dec 2024 23:37:50 +1100, Julien Fischer <jfischer at opturion.com> wrote:

> On Wed, 4 Dec 2024 at 02:58, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> 
> > On Tue, 3 Dec 2024 19:10:19 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> > > > I think that the conceptually cleanest solution of this bug is to make
> > > > the --libgrade option serve only the second purpose, eliminating (1)
> > > > from the preference order entirely. We would compute the set of installed
> > > > stdlib grades in handle_options.m just after we compute chosen_stdlib_dir,
> > > > and record the result in a new slot in the globals structure.
> > >
> > > That seems a reasonable suggestion.
> >
> > Then I will implement it, including the include/exclude-component bits.

The attached diff does this; it is for review by anyone. The diff
adds a new, non-misleading name for the option now named --detect-libgrades.
Would anyone object if I made this new name, --detect-stdlib-grades, replace
the old name, rather than just being a synonym? I will update NEWS when
I know the answer.

> > But before I do, I wanted to separate out the code that sets up chosen_stdlib_dir.
> > The attached diff does this. It has no logic changes that need to be reviewed,
> > but it does have a big new XXX that describes an issue that would arise if/when
> > we started using chosen_stdlib_dir more widely. I am requesting feedback
> > on that XXX, and particularly on the two pathways forward it describes.

I have not yet started work on this. But I also prefer the second
approach, so that is what I will implement.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.oslg
Type: application/octet-stream
Size: 4468 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20241212/08881b7f/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.oslg
Type: application/octet-stream
Size: 67976 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20241212/08881b7f/attachment-0003.obj>