[m-rev.] for review: io.stream_db.m

[Julien Fischer]

On Fri, 11 Mar 2022, Peter Wang wrote:

> On Fri, 11 Mar 2022 17:44:47 +1100 Julien Fischer <jfischer at opturion.com> wrote:
>>
>> On Fri, 11 Mar 2022, Zoltan Somogyi wrote:
>>
>>> 2022-03-11 16:14 GMT+11:00 "Peter Wang" <novalazy at gmail.com>:
>>>>
>>>> I would leave get_stream_id in io.m along with the definitions of the
>>>> stream type, and other stream_id stuff.
>>>
>>> get_stream_id is called only from io.stream_db.m, and nowhere else.
>>> If the id field of streams had another use besides being the key in the
>>> stream db, I would agree with you, but it does not.
>>>
>>> Julien, would you care to break the tie?
>>
>> My inclination would be to put them all in io.stream_db.m, if some
>> of the functionality related to the stream DB is in that submodule
>> I would expect to find all of it there.
>>
>> Peter, what's your reason for wanting to keep it in io.m.
>
> It's an accessor function for a field of `stream', which is defined in
> io.m. No big deal either way.

Ok, I'm still inclined to place it in the submodule however.

Related to this: why is there a declaration for the type stream_id/0
in the publicly documented interface of io.m?  There's nothing in that
part of the interface that would allows users to do anything with a
stream_id value.

Julien.