[m-rev.] for review: io.stream_db.m
Peter Wang
novalazy at gmail.com
Fri Mar 11 17:55:45 AEDT 2022
On Fri, 11 Mar 2022 17:44:47 +1100 Julien Fischer <jfischer at opturion.com> wrote:
>
> On Fri, 11 Mar 2022, Zoltan Somogyi wrote:
>
> > 2022-03-11 16:14 GMT+11:00 "Peter Wang" <novalazy at gmail.com>:
> >>
> >> I would leave get_stream_id in io.m along with the definitions of the
> >> stream type, and other stream_id stuff.
> >
> > get_stream_id is called only from io.stream_db.m, and nowhere else.
> > If the id field of streams had another use besides being the key in the
> > stream db, I would agree with you, but it does not.
> >
> > Julien, would you care to break the tie?
>
> My inclination would be to put them all in io.stream_db.m, if some
> of the functionality related to the stream DB is in that submodule
> I would expect to find all of it there.
>
> Peter, what's your reason for wanting to keep it in io.m.
It's an accessor function for a field of `stream', which is defined in
io.m. No big deal either way.
Peter
More information about the reviews
mailing list