[m-rev.] for review: read and write bitmaps in bitmap.m

[Julien Fischer]

On Sat, 5 Mar 2022, Zoltan Somogyi wrote:

> 2022-03-05 19:10 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>>> Read and write bitmaps in bitmap.m.
>>>> library/io.m:
>>>     Move the implementations of the predicates that read and write bitmaps
>>>     to bitmap.m. Leave forward predicates in io.m, but mark them obsolete.
>>>
>>>     Mark the predicates that get, set and update the globals structure
>>>     stored in the I/O state as obsolete.
>>
>> That's a fairly significant change and should be mentioned in the head of the
>> log message as well.
>
> If you can tell me how to do it in 51 chars or less, I will update the top line.

You don't need to to put in the top line.  Just add another entry
underneath the existing one.

>> (I have some reservations regarding
>> update_globals/3 that I mentioned in the other thread.)
>
> Yes, but do you consider them grounds for *not* marking
> these three predicates obsolete?

No.

>> Has this change been checked in the C# and Java grades?
>
> It is being bootchecked in C# right now; it is in the middle of tests/hard_coded.
> Java is next.
>
>> (If not, you
>> should do so to check that the access modifiers on the methods of the
>> underlying file stream implementations are still appropriate when the
>> bitmap code is in its new location
>
> I have no idea how to do that.

Changing them from private to public would work.  Let's see if there
is a problem first.

Julien.