[m-rev.] for review: read and write bitmaps in bitmap.m

[Zoltan Somogyi]

2022-03-05 19:10 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> Read and write bitmaps in bitmap.m.
>> > library/io.m:
>>     Move the implementations of the predicates that read and write bitmaps
>>     to bitmap.m. Leave forward predicates in io.m, but mark them obsolete.
>>
>>     Mark the predicates that get, set and update the globals structure
>>     stored in the I/O state as obsolete.
> 
> That's a fairly significant change and should be mentioned in the head of the
> log message as well.

If you can tell me how to do it in 51 chars or less, I will update the top line.

> (I have some reservations regarding
> update_globals/3 that I mentioned in the other thread.)

Yes, but do you consider them grounds for *not* marking
these three predicates obsolete?

> Has this change been checked in the C# and Java grades? 

It is being bootchecked in C# right now; it is in the middle of tests/hard_coded.
Java is next.

> (If not, you
> should do so to check that the access modifiers on the methods of the
> underlying file stream implementations are still appropriate when the
> bitmap code is in its new location

I have no idea how to do that.

> -- it looks correct, but installing
> the library in both of those grades will tell you definitively.)

OK, I will try that before commit.

> I assume that some of the tests covering bitmaps will need to updated
> at some point to remove calls to obsolete predicates.

I thought so too, but an asm_fast.gc bootcheck had no failed tests; either no
test case calls the obsoleted predicates, or the ones that do also ignore
that warning. The latter would not be difficult, since --halt-at-warn is NOT
the default for test cases. I will look for such warnings tomorrow.

Thanks for the review.

Zoltan.