[m-rev.] for post-commit review: organize array.m, bt_array.m and pprint.m

Julien Fischer jfischer at opturion.com
Mon Jun 13 14:46:49 AEST 2022


On Sun, 12 Jun 2022, Zoltan Somogyi wrote:

> 2022-06-12 13:41 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
>>> In cord.m, get_first is next to get_last; it does not make sense to have
>>> the latter without the former. List.m does not have get_last, but it does have
>>> just "last".
>>
>> The general principle is that modules that provide a sequence ADT should
>> have (as far as possible) a consistent interface.
>
> Agreed. I brought up that inconsistency specifically to get people's opinion
> on how that inconsistency should be resolved.

The predicate last should be added to cord.m and get_last deprecated.
In general, I would use names, argument orderings etc from the list
module.

Julien.


More information about the reviews mailing list