[m-rev.] for post-commit review: organize array.m, bt_array.m and pprint.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun Jun 12 19:38:27 AEST 2022


2022-06-12 13:41 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
>> In cord.m, get_first is next to get_last; it does not make sense to have
>> the latter without the former. List.m does not have get_last, but it does have
>> just "last".
> 
> The general principle is that modules that provide a sequence ADT should
> have (as far as possible) a consistent interface.

Agreed. I brought up that inconsistency specifically to get people's opinion
on how that inconsistency should be resolved.

>>     Add det predicates det_head and det_tail next to their semidet function
>>     versions (which should be deprecated).
> 
> Do you mean the their det function versions there? And I don't think the det
> function versions should be deprecated.

You are right; I didn't finish adjusting the copied-and-pasted text.
 
> The additions to the cord and list modules should be mentioned in the
> NEWS file.

Done. Thanks for the review.

Zoltan.


More information about the reviews mailing list