[m-rev.] for testing: list all may-introduce-calls-to predicates

Julien Fischer jfischer at opturion.com
Thu Feb 17 22:49:40 AEDT 2022

On Thu, 17 Feb 2022, Zoltan Somogyi wrote:

> There are some XXXs that may be worth reading,
> but the rest of the file cannot be effectively reviewed
> by humans, because what's there cannot be the cause
> of a bug; bugs can be caused only by stuff being *missing*.
> I tracked down the predicates and functions we may introduce
> calls to by looking for plain_call and call_foreign_proc goals
> being constructed, and tracking where their pred_ids came from.
> If a pred_id came from the lookup of the name of a predicate
> or of a function, I included them in the list. However, since
> it is possible that I may have missed some, this diff should
> be tested thoroughly. Julien, can you please exercise
> a compiler with this diff with all the grade/optlevel combinations
> you tested the release with on your -j16 machine? That is
> the "review" that this diff needs.

Shall do. That machine is currently occupied by the most recent batch
of release testing. That should finish some time tomorrow.  I'll set
something up to run over the weekend.

> And Julien, thanks for the prompt review of the arity diff.

You're welcome.


More information about the reviews mailing list