[m-rev.] for testing: list all may-introduce-calls-to predicates

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Feb 17 22:21:00 AEDT 2022


This diff affects only one file, but it rewrites that file almost
completely, so I am sending the file instead of a diff.

There are some XXXs that may be worth reading,
but the rest of the file cannot be effectively reviewed
by humans, because what's there cannot be the cause
of a bug; bugs can be caused only by stuff being *missing*.

I tracked down the predicates and functions we may introduce
calls to by looking for plain_call and call_foreign_proc goals
being constructed, and tracking where their pred_ids came from.
If a pred_id came from the lookup of the name of a predicate
or of a function, I included them in the list. However, since
it is possible that I may have missed some, this diff should
be tested thoroughly. Julien, can you please exercise
a compiler with this diff with all the grade/optlevel combinations
you tested the release with on your -j16 machine? That is
the "review" that this diff needs.

And Julien, thanks for the prompt review of the arity diff.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ict2
Type: application/octet-stream
Size: 247 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220217/133f8966/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: introduced_call_table.m
Type: application/octet-stream
Size: 24599 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220217/133f8966/attachment-0003.obj>


More information about the reviews mailing list