[m-rev.] for review: add some unboxed readers fro binary input streams

Julien Fischer jfischer at opturion.com
Mon Oct 11 12:27:58 AEDT 2021


On Mon, 11 Oct 2021, Zoltan Somogyi wrote:

> 2021-10-11 00:39 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> +    % Reads a single signed 8-bit integer from the specified binary input
>> +    % stream. This interface avoids memory allocation when there is no error.
>> +    %
>> +:- pred read_binary_int8_unboxed(io.binary_input_stream::in, io.result::out,
>> +    int8::out, io::di, io::uo) is det.
>> +% NOTE_TO_IMPLEMENTORS there is no version without an explicit stream argument
>
> s/there/There/, and add a final period.

Fixed.

>> @@ -599,6 +606,13 @@
>>  :- pred read_binary_uint8(io.binary_input_stream::in, io.result(uint8)::out,
>>      io::di, io::uo) is det.
>>
>> +    % Reads a single unsigned 8-bit integer from the specified binary input
>> +    % stream. This interface avoids memory allocation when there is no error.
>> +    %
>> +:- pred read_binary_uint8_unboxed(io.binary_input_stream::in, io.result::out,
>> +    uint8::out, io::di, io::uo) is det.
>> +% NOTE_TO_IMPLEMENTORS there is no version without an explicit stream argument
>
> Same here.

Fixed.

Julien.


More information about the reviews mailing list