[m-rev.] for review: add some unboxed readers fro binary input streams

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Oct 11 05:42:34 AEDT 2021


2021-10-11 00:39 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
> +    % Reads a single signed 8-bit integer from the specified binary input
> +    % stream. This interface avoids memory allocation when there is no error.
> +    %
> +:- pred read_binary_int8_unboxed(io.binary_input_stream::in, io.result::out,
> +    int8::out, io::di, io::uo) is det.
> +% NOTE_TO_IMPLEMENTORS there is no version without an explicit stream argument

s/there/There/, and add a final period.

> @@ -599,6 +606,13 @@
>  :- pred read_binary_uint8(io.binary_input_stream::in, io.result(uint8)::out,
>      io::di, io::uo) is det.
> 
> +    % Reads a single unsigned 8-bit integer from the specified binary input
> +    % stream. This interface avoids memory allocation when there is no error.
> +    %
> +:- pred read_binary_uint8_unboxed(io.binary_input_stream::in, io.result::out,
> +    uint8::out, io::di, io::uo) is det.
> +% NOTE_TO_IMPLEMENTORS there is no version without an explicit stream argument

Same here. The diff is fine otherwise.

Zoltan.


More information about the reviews mailing list